Always show panel if a menu is open on it#11779
Conversation
…to auto hide The problem is that the panel reports it's not visible even though it is, so the x,y calculation for PopupMenus are incorrect. Panels are not hidden until `global.menuStackLength` is bigger than one (meaning a PopupMenu is open for example)
|
@clefebvre I don't really see what this merge achieves except that the option to not show the panel when the menu is opened by shortcut key is no longer available (and thus now needs to be removed from the menu applet #12536) Was that the intention? The original issue that I think this was intended to fix (#10970) was fixed with #11788 btw, if the intention is to remove the option and always show the panel then could that not be more easily be achieved by simply removing the option from the menu applet. |
|
I think when this PR was opened and again when it was merged, everyone just missed that the option was even there. There was no reason for this unless the option is going to be removed. |
|
This PR is was:
Before the fixes the opening behaviour was visually problematic, the panel height (in auto-hide or intelligent mode) was not always considered when showing an applet menu when it should've been, resulting in in the menu either hiding behind the panel or it's position changing after opening, neither being good. With more work it might be possible to always show the applet menu in the correct y position but that won't change the fact that it could move around (which is never a good thing), so that would need to be prevented too. In retrospect this fix might not be the best for everyone, because it seems some people want different show/hide behaviour for each applet. Nevertheless, I don't really mind what happens to this PR, will it be reverted or not, at the time this was the easiest fix I could think of that fixes all of the problems above. |
instead of the current policy of "Don't hide the panel if a menu is open on it". With this, if you open an applet with a keybinding, the panel for it will also show.
I made these changes for another PR, so I thought I open it. Discuss it among yourselves if it's really needed.
Maybe it can be turned into an optional toggle (feature) turning this change into a conditional.